Fix warnings #140
Merged
Fix warnings #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
suggested changes
Oct 30, 2017
smart_open/tests/test_smart_open.py
Outdated
|
|
||
| def test_write_read_bz2(self): | ||
| """Can write and read bz2?""" | ||
| test_file = tempfile.NamedTemporaryFile('wb', suffix='.bz2', delete=False).name | ||
| self.write_read_assertion(test_file) | ||
| with tempfile.NamedTemporaryFile('wb', suffix='.bz2', delete=False) as file: |
There was a problem hiding this comment.
small nitpick - can you rename file (because this is type in python), for example, use infile (here and anywhere)
smart_open/smart_open_lib.py
Outdated
| @@ -530,11 +543,11 @@ def compression_wrapper(file_obj, filename, mode): | |||
| from bz2file import BZ2File | |||
| else: | |||
| from bz2 import BZ2File | |||
| return make_closing(BZ2File)(file_obj, mode) | |||
| return make_closing(BZ2File, file_obj)(file_obj, mode) | |||
There was a problem hiding this comment.
looks slightly strange file_obj)(file_obj
There was a problem hiding this comment.
Tried redo as just classes
menshikh-iv
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.