Fix error message when Doc2Vec does not receive corpus_file or corpus iterable #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
approved these changes
Jun 23, 2021
Of course! My team didn't notice any other instances of |
|
@mpenkov good to merge or not? |
mpenkov
approved these changes
Dec 4, 2021
|
Merging. Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message thrown when you do not include
corpus_fileorcorpus_iterableto the doc2vec model is incorrect, stating that you can set thedocumentsvalue. This change simply makes the error message more accurate so others going through a gensim 3.x to 4.0 migration don't run into issues if they were previously usingdocuments.