Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var.additional_security_group_ids not in use by the module #27

Open
danielmapar opened this issue Jun 26, 2024 · 2 comments
Open

var.additional_security_group_ids not in use by the module #27

danielmapar opened this issue Jun 26, 2024 · 2 comments

Comments

@danielmapar
Copy link

Just a heads up that var.additional_security_group_ids is not being used by the aws_network_interface resource.

A visible fix is to point security_groups = [aws_security_group.main.id] to security_groups = local.security_groups

Great work with the module!
@danielmapar danielmapar mentioned this issue Jun 26, 2024
Open
@danielmapar
Copy link
Author

A quick PR: #28

@kieranbrown
Copy link
Contributor

kieranbrown commented Jul 29, 2024 •
edited
Loading

Hey @danielmapar, I thought the same thing too and also raised a PR for this, but this is the intended behaviour - see the following comment #9 (comment)

@a0s a0s mentioned this issue Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielmapar @kieranbrown