Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables #84

Closed
motiwari opened this issue Aug 12, 2021 · 1 comment · Fixed by #86
Closed

Remove unused variables #84

motiwari opened this issue Aug 12, 2021 · 1 comment · Fixed by #86
Assignees

Comments

@motiwari
Copy link

Hi, thanks for making this code. We are using it in https://github.com/ThrunGroup/BanditPAM.

When compiling the code we get the following warnings:

headers/carma/include/carma_bits/cnumpy.h:277:9: warning: unused variable 'ret_code' [-Wunused-variable]
      int ret_code = api.PyArray_CopyInto_(tmp, src);
          ^
  In file included from src/banditpam.cpp:8:
  In file included from headers/kmedoids_algorithm.hpp:4:
  In file included from headers/log_helper.hpp:4:
  In file included from headers/carma/include/carma:59:
  In file included from headers/carma/include/carma_bits/arraystore.h:25:
  In file included from headers/carma/include/carma_bits/converters.h:29:
  headers/carma/include/carma_bits/numpytoarma.h:93:13: warning: unused variable 'dims' [-Wunused-variable]
      ssize_t dims = src.ndim;
              ^
  headers/carma/include/carma_bits/numpytoarma.h:168:13: warning: unused variable 'dims' [-Wunused-variable]
      ssize_t dims = src.ndim;
              ^
  headers/carma/include/carma_bits/numpytoarma.h:224:13: warning: unused variable 'dims' [-Wunused-variable]
      ssize_t dims = src.ndim;
              ^
  headers/carma/include/carma_bits/numpytoarma.h:281:13: warning: unused variable 'dims' [-Wunused-variable]
      ssize_t dims = src.ndim;
              ^
  5 warnings generated.
@RUrlus RUrlus self-assigned this Aug 13, 2021
@RUrlus
Copy link
Owner

RUrlus commented Aug 16, 2021

@motiwari Thanks for reporting, Clangd doesn't seem to want to catch these for some reason.
Fixed in 2cced75.

I'll create a new release later today which will include this

@RUrlus RUrlus mentioned this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants