Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure vs Assay and where to put Experiments, Analytical Workflows, and Files #41

Open
diatomsRcool opened this issue Jan 3, 2025 · 4 comments

Comments

@diatomsRcool
Copy link
Contributor

diatomsRcool commented Jan 3, 2025

What is the different between Procedure and Assay?
Where would an experimental procedure or an analytical workflow/procedure fit in the model?
Do we need to add Experimental Procedure and/or Analytical Procedure as a child of Procedure? Are experiments included in Lab Procedure?
See the Analysis node types in the BDC Gen3 documentation for some examples of Analytical Procedures.
See the properties of "Read Group" for examples of metadata that might be attributes of an Experimental Procedure element.
I suspect some File types in Gen3 result from analysis of other File types, procedures, and assays so, this has bearing on how Files are modeled as well.
https://gen3.biodatacatalyst.nhlbi.nih.gov/DD

@diatomsRcool diatomsRcool changed the title Experimental Procedure? Procedure vs Assay and where to put Experiments and Analytical Workflows Jan 3, 2025
@diatomsRcool diatomsRcool changed the title Procedure vs Assay and where to put Experiments and Analytical Workflows Procedure vs Assay and where to put Experiments, Analytical Workflows, and Files Jan 3, 2025
@bfurner
Copy link
Collaborator

bfurner commented Jan 6, 2025

a Procedure in this model was conceived as a healthcare procedure, either diagnostic or therapeutic. so things like an MRI, phlebotomy, surgical resection, cardiac ablation. this wasn't originally intended to cover metadata about assays or analytical workflows. are those things that need to be covered in this pilot? if not i would suggest we defer modeling those until we have addressed all the pilot items

@diatomsRcool
Copy link
Contributor Author

I think a way to find out how much of the model we need for the pilot is to look at the priority variables and figure out which parts of the model are needed to manage those.

@bfurner
Copy link
Collaborator

bfurner commented Jan 7, 2025

Right, I hadn't seen anything in the variables which indicated we needed to model experiments or analytical workflows which is why I asked. The variables seem to be entirely clinical.

@diatomsRcool
Copy link
Contributor Author

OK, I'll leave this issue open for the moment, but we won't worry about it until after the pilot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants