Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data folder mode doesn't work due to missing line of code #63

Closed
TorutheRedFox opened this issue Jan 20, 2021 · 5 comments
Closed

Data folder mode doesn't work due to missing line of code #63

TorutheRedFox opened this issue Jan 20, 2021 · 5 comments
Labels
hiprio Needs to be fixed ASAP
Milestone
1.1.0

Comments

@TorutheRedFox
Copy link
Contributor

the missing line is "StrCopy(fileInfo->fileName, filePath);" at LoadFile() in Reader.cpp
@stxticOVFL
Copy link
Collaborator

Can you please make a pull request or tell me what line it's supposed to be in?

@TorutheRedFox
Copy link
Contributor Author

line 156 in Reader.cpp
image

@stxticOVFL stxticOVFL added the hiprio Needs to be fixed ASAP label Jan 20, 2021
@stxticOVFL stxticOVFL added this to the 1.1.0 milestone Jan 20, 2021
@stxticOVFL
Copy link
Collaborator

Missing line of code appears to mitigate the issue, but eventually crashes anyway, as far as I'm aware.

@stxticOVFL
Copy link
Collaborator

Fixed in 0b89c10.

@TorutheRedFox
Copy link
Contributor Author

the crash happens due to a different issue, as it happens with the RSDK too, and the log doesn't say that it failed to load something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hiprio Needs to be fixed ASAP
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@TorutheRedFox @stxticOVFL