From 1b0716efd7b40e87d82406cb31c158e207adeb14 Mon Sep 17 00:00:00 2001
From: RS146BIJAY <rishavsagar4b1@gmail.com>
Date: Thu, 22 Aug 2024 11:38:32 +0530
Subject: [PATCH] Skipping serialization of node attributes in Leader and
 follower checks

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
---
 .../coordination/FollowersChecker.java        |  7 ++++-
 .../cluster/node/DiscoveryNode.java           | 27 +++++++++++++++----
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/server/src/main/java/org/opensearch/cluster/coordination/FollowersChecker.java b/server/src/main/java/org/opensearch/cluster/coordination/FollowersChecker.java
index 2ec0dabd91786..8a93c2dd42355 100644
--- a/server/src/main/java/org/opensearch/cluster/coordination/FollowersChecker.java
+++ b/server/src/main/java/org/opensearch/cluster/coordination/FollowersChecker.java
@@ -35,6 +35,7 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.message.ParameterizedMessage;
+import org.opensearch.Version;
 import org.opensearch.cluster.ClusterManagerMetrics;
 import org.opensearch.cluster.coordination.Coordinator.Mode;
 import org.opensearch.cluster.node.DiscoveryNode;
@@ -503,7 +504,11 @@ public FollowerCheckRequest(final StreamInput in) throws IOException {
         public void writeTo(final StreamOutput out) throws IOException {
             super.writeTo(out);
             out.writeLong(term);
-            sender.writeTo(out);
+            if (out.getVersion().onOrAfter(Version.V_2_17_0)) {
+                sender.writeToWithoutAttribute(out);
+            } else {
+                sender.writeTo(out);
+            }
         }
 
         @Override
diff --git a/server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java b/server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java
index 653f81830ed17..af7b8605fcd6e 100644
--- a/server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java
+++ b/server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java
@@ -358,17 +358,35 @@ public DiscoveryNode(StreamInput in) throws IOException {
 
     @Override
     public void writeTo(StreamOutput out) throws IOException {
+        writeToUtil(out, true);
+    }
+
+    public void writeToWithoutAttribute(StreamOutput out) throws IOException {
+        if (out.getVersion().onOrAfter(Version.V_2_17_0)) {
+            writeToUtil(out, false);
+        } else {
+            writeToUtil(out, true);
+        }
+    }
+
+    private void writeToUtil(StreamOutput out, boolean includeAttributes) throws IOException {
         out.writeString(nodeName);
         out.writeString(nodeId);
         out.writeString(ephemeralId);
         out.writeString(hostName);
         out.writeString(hostAddress);
         address.writeTo(out);
-        out.writeVInt(attributes.size());
-        for (Map.Entry<String, String> entry : attributes.entrySet()) {
-            out.writeString(entry.getKey());
-            out.writeString(entry.getValue());
+        if (includeAttributes) {
+            out.writeVInt(attributes.size());
+            for (Map.Entry<String, String> entry : attributes.entrySet()) {
+                out.writeString(entry.getKey());
+                out.writeString(entry.getValue());
+            }
+        } else {
+            // Set the size of attribute as 0 so that no attribute is read from stream on receiver node.
+            out.writeVInt(0);
         }
+
         out.writeVInt(roles.size());
         for (final DiscoveryNodeRole role : roles) {
             final DiscoveryNodeRole compatibleRole = role.getCompatibilityRole(out.getVersion());
@@ -566,7 +584,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
         builder.field("name", getName());
         builder.field("ephemeral_id", getEphemeralId());
         builder.field("transport_address", getAddress().toString());
-
         builder.startObject("attributes");
         for (Map.Entry<String, String> entry : attributes.entrySet()) {
             builder.field(entry.getKey(), entry.getValue());