Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build date is always UTC, even with different time zone settings #72

Closed
g-e-r opened this issue May 24, 2017 · 2 comments
Closed

The build date is always UTC, even with different time zone settings #72

g-e-r opened this issue May 24, 2017 · 2 comments

Comments

@g-e-r
Copy link

g-e-r commented May 24, 2017

This took me some time to find out.
My timezone - PDT - is UTC-7
So if I start a build and it fails after 5pm, the date will change...
That happens very often in the US West coast.
there should be a better strategy for this.

@thomas-phillips-nz
Copy link
Contributor

thomas-phillips-nz commented Jun 1, 2017

In build.sh, line 131, it assigns the IMG_DATE variable to the current UTC date if the IMG_DATE variable is not set. You should be able to invoke the script using:
IMG_DATE=`date +%Y-%m-%d` ./build.sh if you want to set your own date. However, this won't work with the Docker build script (the docker container will be using UTC), you will have to set IMG_DATE in your config file prior to running it.

That said, I don't like the fact that the date is UTC either. I propose we change it to always use the local system timezone. It can always be overridden using the IMG_DATE variable.

Also, it's minor, but the title of a bug should state what is happening (what problem you are observing), not what the solution is. E.g. "The build date is always UTC, even with different time zone settings" or "The build date does not honour the local timezone", or something like that

@g-e-r g-e-r changed the title should not use UTC time as build date The build date is always UTC, even with different time zone settings Jun 2, 2017
@XECDesign
Copy link
Member

Fixed by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants