Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with new HOSTNAME feature #381

Open
bit-bash opened this issue Jan 20, 2020 · 2 comments
Open

Some issues with new HOSTNAME feature #381

bit-bash opened this issue Jan 20, 2020 · 2 comments

Comments

@bit-bash
Copy link

bit-bash commented Jan 20, 2020

Since the new HOSTNAME feature was added in commits:
d30343f
95ba042
I've noticed a few minor-ish issues.

First, in stage1/02-net-tweaks/00-run.sh, the line:
echo "127.0.1.1\t\t${HOSTNAME}" >> "${ROOTFS_DIR}/etc/hosts"
has two tabs - it should be only ONE tab to be consistent with previous builds and to prevent regressions with derivative repos (such as teslausb which expects one tab for its patch process).

Second, if build.sh is run multiple times, /etc/hosts will end up with multiple 127.0.1.1... lines. Each time build.sh is run a new line like this will be added to /etc/hosts. It might be prudent for the shell script to check to see if a 127.0.1.1 line already exists before appending a new one.

Thirdly, when building with the recommended ubuntu 16.04 32-bit distro, HOSTNAME already exists by the OS. Therefore, the default of "raspberrypi" is not quite true in the README.md file. I had to add HOSTNAME=raspberrypi to my config file otherwise the hostname of the built target took on the name of my ubuntu 16.04 host.

Oh, and slightly off-topic, to get everything to build with ubuntu 16.04 32-bit, I had to install:
qemu-user-static_4.0+dfsg-0ubuntu9.2_i386.deb
binfmt-support_2.2.0-2_i386.deb
from ubuntu eoan-updates. The default qemu-user-static package for ubuntu 16.04 is too old to handle debian buster images.

Sorry, I'm a bit of a github noob, if someone could learn me how to to pull requests, I could add these issues to such. ;)

@XECDesign
Copy link
Member

Thanks for the helpful bug report.

@bit-bash
Copy link
Author

Looks like issue #3 has been addressed by 24bb01d

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants