Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures inside on_chroot do not stop the build #217

Closed
tomas-c opened this issue Nov 6, 2018 · 2 comments
Closed

Failures inside on_chroot do not stop the build #217

tomas-c opened this issue Nov 6, 2018 · 2 comments

Comments

@tomas-c
Copy link

tomas-c commented Nov 6, 2018

Most build scripts have "-e" option which is meant to make failed commands interrupt the script.

However, if any commands fail inside on_chroot call, the build still continues.

This seems a bit risky as you can only notice failures by carefully analysing build logs.

Replacing all instances of on_chroot with on_chroot -e fixes this.

@XECDesign
Copy link
Member

Good idea. Does only changing https://github.com/RPi-Distro/pi-gen/blob/master/scripts/common#L91 to capsh --drop=cap_setfcap "--chroot=${ROOTFS_DIR}/" -- "-e $@" do the job?

@tomas-c
Copy link
Author

tomas-c commented Nov 8, 2018

It works if I move -e outside the quotes. I have created #219 with the necessary code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants