We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most build scripts have "-e" option which is meant to make failed commands interrupt the script.
However, if any commands fail inside on_chroot call, the build still continues.
on_chroot
This seems a bit risky as you can only notice failures by carefully analysing build logs.
Replacing all instances of on_chroot with on_chroot -e fixes this.
on_chroot -e
The text was updated successfully, but these errors were encountered:
Good idea. Does only changing https://github.com/RPi-Distro/pi-gen/blob/master/scripts/common#L91 to capsh --drop=cap_setfcap "--chroot=${ROOTFS_DIR}/" -- "-e $@" do the job?
capsh --drop=cap_setfcap "--chroot=${ROOTFS_DIR}/" -- "-e $@"
Sorry, something went wrong.
It works if I move -e outside the quotes. I have created #219 with the necessary code changes.
No branches or pull requests
Most build scripts have "-e" option which is meant to make failed commands interrupt the script.
However, if any commands fail inside
on_chroot
call, the build still continues.This seems a bit risky as you can only notice failures by carefully analysing build logs.
Replacing all instances of
on_chroot
withon_chroot -e
fixes this.The text was updated successfully, but these errors were encountered: