Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: amdgcn-cfg.py fails to create CFG for the FA kernel - i.e., attn_fwd kernel #671

Open
ravil-mobile opened this issue Dec 2, 2024 · 0 comments
Assignees

Comments

@ravil-mobile
Copy link

Problem Description

amdgcn-cfg.py fails to create an edge because there is the following basic block in the middle. The script didn't take into account an early kernel terminator

.LBB0_40:
	.loc	1 626 4                         ; flash-attention.py:626:4
	s_endpgm

The CFG logic needs to be fixed (somewhere around get_block_list function).

The output looks as follows If one deletes LBB0_40 label and a jump to this label

attn_fwd svg kernel-0

Operating System

Ubuntu 22.04.5 LTS

CPU

MI300X

GPU

AMD

ROCm Version

ROCm 6.2.3

ROCm Component

ROCm

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ravil-mobile ravil-mobile self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant