Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rocprofv2 should be accepted for gfx908 #559

Open
IMbackK opened this issue Feb 10, 2025 · 0 comments
Open

[Bug]: Rocprofv2 should be accepted for gfx908 #559

IMbackK opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
bug Something isn't working triage

Comments

@IMbackK
Copy link

IMbackK commented Feb 10, 2025

Describe the bug

rocprofv2 is supported on gfx908 see:
https://github.com/ROCm/rocprofiler/blob/amd-staging/README.md

However rocprofv2 is masked away on gfx908 by:

self.set_compatible_profilers(["rocprofv1", "rocscope", "rocprofv3"])

Eiting this line to read 'self.set_compatible_profilers(["rocprofv1", "rocprofv2", "rocscope", "rocprofv3"])'
allows:
ROCPROF=rocprofv2 install/3.0.0/bin/rocprof-compute profile -V -V -n occupancy -k vgprbound --kernel-names vgprbound rocprofiler-compute/sample/occupancy to complete with out problems, and all metrics actually supported by gfx908 (see issue #558) work fine.

Further rocprofv1 appears to be currently broken see #521

Linux Distribution

any

ROCm Compute Profiler Version

git @ 3396ba3

GPU

MI100

ROCm Version

6.3.2

Cluster name (if applicable)

No response

Reproducer

ROCPROF=rocprofv2 rocprof-compute profile -V -V -n occupancy -k vgprbound --kernel-names vgprbound rocprofiler-compute/sample/occupancy

Expected behavior

rocprofv2 should be allowed on gfx908, it works fine.

Relevant log output

Screenshots

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants