Optimize LU factorization without pivoting #680
+2,221
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add potf2_lds to specialized kernels folder
EdDAzevedo
requested review from
jzuniga-amd,
tfalders,
cgmb and
qjojo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize getrf_npvt (LU factorization without pivoting) by using a block algorithm that is similar to the block algorithm used in Cholesky factorization.
The diagonal block is factored using a specialized kernel that loads the matrix into the 64 Kbytes of LDS shared memory.
Then rocblas TRSM is used to generate a column panel in "L" and row panel in "U".
Then rocblas GEMM is used to update the right unfactored sub-matrix.
The new routines are named as "getf2_nopiv" and "getrf_nopiv" to make minimal changes to the existing code.