From fa47a5a98338f7a36e68f5343f7a5d14edb22aa3 Mon Sep 17 00:00:00 2001 From: Cong Ma Date: Tue, 5 Nov 2024 23:23:49 +0000 Subject: [PATCH 1/3] Add unit tests back CK fixed an issue that prevented it from supporting unit tests with beta is not equal to 0. Add these unit tests back. --- test/03_reduction/configs/extended/rank1_test_params.yaml | 2 +- test/03_reduction/configs/extended/rank2_test_params.yaml | 2 +- test/03_reduction/configs/extended/rank3_test_params.yaml | 2 +- test/03_reduction/configs/extended/rank4_test_params.yaml | 2 +- test/03_reduction/configs/extended/rank5_test_params.yaml | 2 +- test/03_reduction/configs/extended/rank6_test_params.yaml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/03_reduction/configs/extended/rank1_test_params.yaml b/test/03_reduction/configs/extended/rank1_test_params.yaml index 899fe99a..340a7e55 100644 --- a/test/03_reduction/configs/extended/rank1_test_params.yaml +++ b/test/03_reduction/configs/extended/rank1_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 13 ] - [ 6 ] diff --git a/test/03_reduction/configs/extended/rank2_test_params.yaml b/test/03_reduction/configs/extended/rank2_test_params.yaml index a790cbfa..89d9ee6d 100644 --- a/test/03_reduction/configs/extended/rank2_test_params.yaml +++ b/test/03_reduction/configs/extended/rank2_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 13, 11] - [ 6, 4] diff --git a/test/03_reduction/configs/extended/rank3_test_params.yaml b/test/03_reduction/configs/extended/rank3_test_params.yaml index 19fb42df..3d30f55a 100644 --- a/test/03_reduction/configs/extended/rank3_test_params.yaml +++ b/test/03_reduction/configs/extended/rank3_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 11, 8, 5] - [ 5, 6, 4] diff --git a/test/03_reduction/configs/extended/rank4_test_params.yaml b/test/03_reduction/configs/extended/rank4_test_params.yaml index f85a612f..60098c5e 100644 --- a/test/03_reduction/configs/extended/rank4_test_params.yaml +++ b/test/03_reduction/configs/extended/rank4_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 13, 11, 8, 5] - [ 3, 5, 6, 4] diff --git a/test/03_reduction/configs/extended/rank5_test_params.yaml b/test/03_reduction/configs/extended/rank5_test_params.yaml index d6c92b0b..fb3a1b8c 100644 --- a/test/03_reduction/configs/extended/rank5_test_params.yaml +++ b/test/03_reduction/configs/extended/rank5_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 13, 11, 8, 5, 4] - [ 3, 5, 6, 4, 5] diff --git a/test/03_reduction/configs/extended/rank6_test_params.yaml b/test/03_reduction/configs/extended/rank6_test_params.yaml index 1e5a54a9..00062cf8 100644 --- a/test/03_reduction/configs/extended/rank6_test_params.yaml +++ b/test/03_reduction/configs/extended/rank6_test_params.yaml @@ -11,7 +11,7 @@ Alphas: - 2.3 Betas: - 0.0 - # - 2.3 + - 2.3 Lengths: - [ 7, 2, 8, 5, 4, 3] - [ 3, 5, 6, 4, 5, 3] From 66197929b606318905e32b8d6813f7a41937c6a9 Mon Sep 17 00:00:00 2001 From: Sandra Polifroni Date: Thu, 24 Oct 2024 14:59:18 -0400 Subject: [PATCH 2/3] updated the changelog for 6.3 --- CHANGELOG.md | 33 ++++++++++++++++++--------------- README.md | 4 ++-- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b89f9e52..53e6e9ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,29 +2,32 @@ Full documentation for hipTensor is available at [rocm.docs.amd.com/projects/hiptensor](https://rocm.docs.amd.com/projects/hipTensor/en/latest/index.html). -## (Unreleased) hipTensor 1.4.0 for ROCm 6.3.0 +## hipTensor 1.4.0 for ROCm 6.3.0 -### Additions +### Added -* Added API support for tensor reduction of ranks 2, 3, 4, 5 and 6 -* Added CPU reference for tensor reductions -* Added unit tests for tensor reductions -* Added documentation for tensor reductions +* Added support for tensor reduction, including APIs, CPU reference, unit tests, and documentation -### Changes +### Changed -* Updated target archs for ASAN builds -* ASAN library builds now use -mcmodel=large to accommodate larger lib size -* Updated permute backend to accommodate changes to element-wise ops implementation -* Updated validation acceptance criteria to match CK backend tests -* Renamed the CMake option `HIPTENSOR_DATA_LAYOUT_COL_MAJOR` to `HIPTENSOR_DEFAULT_STRIDES_COL_MAJOR` +* ASAN builds only support xnack+ targets. +* ASAN builds use `-mcmodel=large` to accommodate library sizes greater than 2GB. +* Updated the permute backend to accommodate changes to element-wise operations. +* Updated the actor-critic implementation. -### Fixes +### Optimized -* Fixed a bug in randomized tensor input data generation -* Various documentation formatting updates and fixes * Split kernel instances to improve build times +### Resolved issues + +* Fixed a bug in randomized tensor input data generation. +* Fixed the default strides calculation to be in column major order. +* Fixed a small memory leak by properly destroying HIP event objects in tests. +* Default strides calculations now follow column-major convention. +* Various documentation formatting updates and fixes. + + ## hipTensor 1.3.0 for ROCm 6.2.0 ### Additions diff --git a/README.md b/README.md index 83c488d9..bae4912a 100644 --- a/README.md +++ b/README.md @@ -30,7 +30,7 @@ Optional: ## Build with CMake -For more detailed information, please refer to the [hipTensor installation guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/installation.html). +For more detailed information, please refer to the [hipTensor installation guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/install/installation.html). ### Project options @@ -74,4 +74,4 @@ The latest official documentation for hipTensor is available at: ## Contributing to the hipTensor Library -Community collaboration is encouraged! If you are considering contributing, please follow the [hipTensor Contribution Guide](https://github.com/ROCm/hipTensor/CONTRIBUTING.md) to get started. +Community collaboration is encouraged! If you are considering contributing, please follow the [hipTensor Contribution Guide](https://rocm.docs.amd.com/projects/hipTensor/en/latest/contribution/contributors-guide.html) to get started. From 6baea606af4d9e32c05873ac1ea20966c062cf08 Mon Sep 17 00:00:00 2001 From: Christopher Millette <63608002+cgmillette@users.noreply.github.com> Date: Mon, 2 Dec 2024 16:41:48 -0700 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 53e6e9ac..a752b3c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,6 @@ Full documentation for hipTensor is available at [rocm.docs.amd.com/projects/hip * Default strides calculations now follow column-major convention. * Various documentation formatting updates and fixes. - ## hipTensor 1.3.0 for ROCm 6.2.0 ### Additions