New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recommendation] Remove all conditionals like MIOPEN_BETA_API #2447

Open

junliume opened this issue Oct 11, 2023 · 2 comments

Assignees

Contributor

junliume commented Oct 11, 2023

[Recommendation] Remove all conditionals like

#ifdef MIOPEN_BETA_API
...
#endif

from the library sources EXCEPT miopen.h.

But this can be done later.

Originally posted by @atamazov in #2430 (comment)

junliume assigned cderb

Contributor Author

junliume commented Oct 11, 2023

@atamazov in case you want to add more details to this issue for progress tracking

Contributor

atamazov commented Oct 31, 2023 •

edited

Loading

Related review thread: Add support for layernorm primitive #2320 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment