Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split check_emission_intensity into check_prep_emission_intensity and check_plot_emission_intensity #546

Closed
jdhoffa opened this issue Feb 13, 2024 · 0 comments · Fixed by #551

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 13, 2024

Also requires adding additional checks to both functions, since it is expected that their inputs should differ dramatically (so likely the checks should too)

          I agree in principle that the `checks` likely should be different as they test different input. However in practice, the were checking the presence of the exact same columns. 

That to me suggests that check_plot_emission_intensity and check_prep_emission_intensity likely should be expanded to include more precise checking, but I think that is out of scope for this PR.

I will open a new issue to that effect.

Originally posted by @jdhoffa in #543 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants