Consider changing the name of the index_regions dataset

[jdhoffa]

DANGEROUS

Likely must be co-ordinated across many repos. Off the top of my head, probably warrants at least looking at:
pacta.data.preparation, portfolio.allocate, and pacta.portfolio.report
and
workflow.data.preparation and workflow.transition.monitor

cc: @cjyetman any other you can think of?

[cjyetman]

probably not so bad... I think it's only on the data.prep side of things these days
https://github.com/search?q=org%3ARMI-PACTA+index_regions+-is%3Aarchived&type=code

[jdhoffa]

Awesome.

I flagged DANGEROUS because it smelled like it might be, and I didn't have the time/ energy to look into it more deeply XD

[cjyetman]

@jdhoffa what would you like to rename it as?

side note: if the intent is to distinguish it from our "indices results", I would suggest changing the names of those instead because they are really "benchmark" results which currently by default contain values from ETFs that track index compositions, but that's not strictly a requirement. index_regions actually contains the regions as specified by the index.

side note: index_regions is only ever used in the data.prep process, specifically in the monster dataprep_abcd_scen_connection(). It is only saved/exported to the outputs to allow reproducibility of the data.prep process (questionably, see RMI-PACTA/workflow.data.preparation#148)

[jdhoffa]

Hmm yeah actually maybe the name is fine, I don't remember why I initially opened this repo, and I didn't add enough context to the ticket. Closing now