Unable to build LZVN on apple m1 #43
Comments
|
On Wednesday September 29 2021 13:50:24 ʞ-uɐʇsıɹʇ wrote:
I'm trying to install your LZVN fork on a macbook air (m1) as described in the README.md but for some reason it fails.
Scanning dependencies of target FastCompression
[ 8%] Building ASM object CMakeFiles/FastCompression.dir/lzvn_decode.S.o
/Users/tristank/Documents/Code/git/github/LZVN/lzvn_decode.S:8:8: error: unknown token in expression
pushq %rbp
There is your reason ... LZVN contains assembly, which is X86 specific. I'd have to see if the original project on which mine is based has ARM64 support by now...
There's support for running Intel binaries, no? Have you tried if that works for afsctool?
|
Yes there is through Rosetta 2. I can successfully build the LZVN binary with |
Is this the same for LZFSE? I notice that the I just got an M1 MBP. |
|
I believe this is fixed, I was able to make this on my m1 mbp by default. |
|
Fingers crossed the next brew version will also include the capability. |
Having seen no changes to include LZVN or LZFSE in afsctool 1.7.3 recently installed via brew... ...I just tried making the latest code on mac M1 Mac. Indeed, @Dr-Emann do you see differently than below? |
|
I do see the same when using a brew-installed afsctool. However, after compiling myself, it works fine. Did you fetch the submodule, either cloning with |
|
Trying again from fresh files, I see the issue. I will have to try again later. |
sub-modules use git not https - you need ssh to github configured. or and all will be fine |
|
Looks like you'll need #59, the git:// protocol isn't allowed on github anymore. |
|
Continued thanks! |
|
Done! And working. Thanks again, all. |
|
On Friday November 11 2022 11:02:02 kapitainsky wrote:
sub-modules use git not https - you need ssh to github configured.
So is the part about having ssh configured still valid or not?
|
|
No, there's no need to be configured with ssh, I think @kapitainsky was confusing the git protocol |
|
@RJVB The only other thing would be that it'd be nice to be able to enable LZVN/LZFSE in the brew builds. It seems like the simplest way would be to configure it to use git directly, rather than the auto-generated source tarball like this, (it seems homebrew will automatically fetch submodules when sourcing from git). The alternative would be to create a release tarball manually which includes the lzfse submodule? Or I do see there's a brew recipe for lzfse, it might be possible to dynamically link with it in the brew case? |
I'm trying to install your LZVN fork on a macbook air (m1) as described in the README.md but for some reason it fails.
The text was updated successfully, but these errors were encountered: