Config feature cleanup

[OlegHahm]

Fixing some side effects of #1846 and #1900.

[LudwigKnuepfer]

why are both necessary?

[OlegHahm]

The first one says that this module should be used, the latter one that the feature is available on the platform. See #1917 (comment).

[LudwigKnuepfer]

So, the module works if the feature isn't available? That seems wrong ;)

[OlegHahm]

If it's not available it won't be able to link and must therefore be disabled.

[OlegHahm]

@Kijewski, I tried to make use of FEATURES_PROVIDED for filtering out the module config from USEMODULES, instead of these ugly ifdefs, but failed.

I tried with something like

USEMODULE = $(filter-out $(filter-out $(FEATURES_PROVIDED), $(FEATURES_OPTIONAL)), $(sort $(USEMODULE)))

but Make didn't like the recursion here. Do you have an idea?

[OlegHahm]

With USEMODULE := it is so much simpler...

[OlegHahm]

@Kijewski, @LudwigOrtmann, you like?

[Kijewski]

Actually, no, sorry. Will elaborate later.

[OlegHahm]

How much later? ;-)

[OlegHahm]

Rebased. @Kijewski, please state what's wrong with this now (or forever hold your peace).

[Kijewski]

What does this line do?

USEMODULE := $(filter-out $(filter-out $(FEATURES_PROVIDED), $(FEATURES_OPTIONAL)), $(sort $(USEMODULE)))

[OlegHahm]

$(filter-out $(FEATURES_PROVIDED), $(FEATURES_OPTIONAL)) returns all optional features that are not provided. The outer filter-out rule then removes all optional, but not available modules from the USEMODULE list.

[Kijewski]

OK, ACK. Seems legitimate for this usecase.

[OlegHahm]

Apparently something is wrong with DEFAULT_MODULES. I'm investigating.

[OlegHahm]

Apparently the DEFAULT_MODULES should be added to the USEMODULE after they are collected also from boards and cpu.

[OlegHahm]

@Kijewski, any better idea or does your ACK hold?

[Kijewski]

My ACK holds