Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at86rf2xx: Same short address for multiple devices #4986

Closed
jnohlgard opened this issue Mar 8, 2016 · 3 comments
Closed

at86rf2xx: Same short address for multiple devices #4986

jnohlgard opened this issue Mar 8, 2016 · 3 comments
Assignees
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Comments

@jnohlgard
Copy link
Member

Since the driver only takes the topmost 16 bits of the cpuid, all my devices get the same short address initially because only some bits of the cpuid vary between the individual units. This does not affect the functionality because long address mode is the default, but still it feels like it should be hashed somehow to let all bits of the cpuid affect the address.

https://github.com/RIOT-OS/RIOT/blob/master/drivers/at86rf2xx/at86rf2xx.c#L125

@jnohlgard jnohlgard added Area: network Area: Networking Area: drivers Area: Device drivers missing feature labels Mar 8, 2016
@jnohlgard jnohlgard added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 8, 2016
@OlegHahm
Copy link
Member

OlegHahm commented Jun 1, 2016

Hm, IIRC IEEE 802.15.4 proposes that initially all devices should have 0xFFFF as short address and the PAN coordinator takes care of assignment. However, I think assigning some kind of pseudo random short addresses at boot-up seems to be somewhat sensible to me (especially since we do not support PAN coordinators). But I don't know how we can make sure that short addresses are somewhat uniq. @PeterKietzmann, @miri64, what was the conclusion from the latest discussion on this topic?

@miri64
Copy link
Member

miri64 commented Jun 1, 2016

See #5457. Basically the current proposal is to refine the calculation process. However, this issue seems to be a duplicate of #5457 so close?

@PeterKietzmann
Copy link
Member

Yes. Short address generation is part of our discussions in #5457. Even if #5457 is more a duplicate of this issue :-) I will close it because there's been more discussions in the other one

@miri64 miri64 added the State: duplicate State: The issue/PR is a duplicate of another issue/PR label Jun 2, 2016
@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

No branches or pull requests

5 participants