Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential race condition in compile_and_test_for_board.py #12621

Open
OYTIS opened this issue Oct 31, 2019 · 3 comments
Open

Potential race condition in compile_and_test_for_board.py #12621

OYTIS opened this issue Oct 31, 2019 · 3 comments
Assignees
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@OYTIS
Copy link
Contributor

OYTIS commented Oct 31, 2019

While working on #9323 I've run into numerous failures of compile_and_test_for_board.py, that seemed to be caused by the board starting before the terminal on the host machine starts. While the test expected to see certain output from the board, it was sometimes missing, and sometimes the beginning was truncated, while flashing an test manually would show correct behaviour.

The error can be reproduced at least with cc2650-launchpad and cc1352-launchpad. I suspect that any board using XDS110 may be affected as well. Probably hardening the test runner so that the terminal always starts before the image is flashed should help.

@stale
Copy link

stale bot commented May 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label May 3, 2020
@aabadie aabadie added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 3, 2020
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label May 3, 2020
@aabadie
Copy link
Contributor

aabadie commented Jul 2, 2020

@fjmolinas I think the work done with test_utils_interactive_sync improved the situation here. @OYTIS maybe you could add a delay before the test actually starts. This is what is done with board where stdio is provided via USB.

TESTRUNNER_CONNECT_DELAY ?= $(TERM_DELAY)
$(call target-export-variables,test,TESTRUNNER_CONNECT_DELAY)

You can define the TERM_DELAY variable with an integer in second.

@miri64 miri64 added this to the Release 2020.07 milestone Jul 6, 2020
@fjmolinas
Copy link
Contributor

@fjmolinas I think the work done with test_utils_interactive_sync improved the situation here. @OYTIS maybe you could add a delay before the test actually starts.

I think this is indeed fixed for most cases, it might still happen for some boards with specific issues, but if that is the case we should open specific issues. I currently have a cc2650-launchpad at hand, I'll run compile_and_test_for_boards and see if its fixed for this board.

@aabadie aabadie added Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools labels May 20, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

5 participants