Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check why only larger than 0 RI values can be written to MSP files #121

Closed
hechth opened this issue Apr 18, 2024 · 0 comments
Closed

Check why only larger than 0 RI values can be written to MSP files #121

hechth opened this issue Apr 18, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@hechth
Copy link
Member

hechth commented Apr 18, 2024 •
edited
Loading

The current implementation of the write function of the MatchMSData class doesn't support writing the value if it is smaller 0.

If we want to allow resetting values etc., we should remove the RI key if the value is 0. The RI values for spectra where there is non numeric information stored is currently set to 0.
@hechth hechth added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Apr 18, 2024
@hechth hechth mentioned this issue Apr 18, 2024
Closed
2 tasks
@hechth hechth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hechth