Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lines 248 - 292 in MFAssignR into a function #37

Open
hechth opened this issue May 16, 2024 · 2 comments
Open

Refactor lines 248 - 292 in MFAssignR into a function #37

hechth opened this issue May 16, 2024 · 2 comments
Assignees
@KristinaGomoryova

Comments

@hechth
Copy link
Member

hechth commented May 16, 2024

The lines are an if ... else block which could be nicely refactored into 3 functions, one for each branch of the condition and one for the whole thing. I also think maybe some parts of the implementation can be shared to make the if ... else part smaller.
@KristinaGomoryova
Copy link
Collaborator

Which particular function in MFAssignR does this relate to?

@hechth
Copy link
Member Author

hechth commented Sep 2, 2024

I think MFAssign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinaGomoryova KristinaGomoryova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hechth @KristinaGomoryova