Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pre Python 3.7 compatibility code for shutil #2066

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jul 29, 2022

Summary of changes

Remove fallback code in case shutil does not have the move function,
noticed this while trying to fix some Windows specific issues.

No tests are added as this functionality is extensively tested.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Remove fallback code in case shutil does not have the move function,
noticed this while trying to fix some Windows specific issues.
@aucampia aucampia marked this pull request as ready for review July 29, 2022 23:47
@aucampia aucampia requested a review from a team July 29, 2022 23:47
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.503% when pulling 74fd1d1 on aucampia:iwana-20220730T0135-remove_compat into ff41218 on RDFLib:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 1d5f3e7 into RDFLib:master Jul 30, 2022
@aucampia aucampia deleted the iwana-20220730T0135-remove_compat branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants