docs: don't use kroki #2284
Merged
docs: don't use kroki #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20230317T1841-kroki
branch
2 times, most recently
from
8f497ac
to
d66563b
Compare
aucampia
force-pushed
the
iwana-20230317T1841-kroki
branch
from
d3835e3
to
ed7101f
Compare
|
Merging without review as this has no runtime changes. |
The kroki server is currently experiencing some issues which breaks our build, this change eliminates the use of kroki in favor of directly using the generated svg images which is checked into git alongside the plantuml sources. I also added a task to the Taskfile to re-generate the svg images from the plantuml sources by calling docker.
aucampia
force-pushed
the
iwana-20230317T1841-kroki
branch
from
ed7101f
to
48f69a7
Compare
aucampia
changed the title
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The kroki server is currently experiencing some issues which breaks our
build, this change eliminates the use of kroki in favour of directly
using the generated SVG images which is checked into git alongside the
plantuml sources.
I also added a task to the Taskfile to re-generate the SVG images from
the plantuml sources by calling docker.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.