separate crates #92
Merged
separate crates #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaries will be moved into separate crate for utilization Signed-off-by: Lakshya Singh <[email protected]>
Signed-off-by: Lakshya Singh <[email protected]>
Signed-off-by: Lakshya Singh <[email protected]>
Signed-off-by: Lakshya Singh <[email protected]>
Signed-off-by: Lakshya Singh <[email protected]>
king-11
force-pushed
the
king-11/separate-crates
branch
from
6ef6f89
to
5fdab28
Compare
RCasatta
approved these changes
Nov 19, 2024
| @@ -157,15 +157,14 @@ mod inner_test { | |||
| use crate::bitcoin::Network; | |||
| use crate::{iterate, Config}; | |||
| use std::sync::mpsc::sync_channel; | |||
| use test_log::test; | |||
There was a problem hiding this comment.
didn't know about this, it's great!
Ideally would have been better to introduce this in a separate commit
| pub skip_prevout: bool, | ||
|
|
||
| /// Maximum length of a reorg allowed, during reordering send block to the next step only | ||
| /// if it has `max_reorg` following blocks. Higher is more conservative, while lower faster. | ||
| /// When parsing testnet blocks, it may be necessary to increase this a lot | ||
| #[arg(short, long, default_value = "6")] | ||
| #[cfg_attr(feature = "clap", arg(short, long, default_value = "6"))] |
There was a problem hiding this comment.
This is great to do now that the crate is separate, but ideally this should have been a move only commit, followed by changes like this one.
There was a problem hiding this comment.
Yeah makes sense I could have kept them separate thanks for insights will try to take care of it in future contributions....one commit one purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #91