Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled more compiler warnings #813

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Enabled more compiler warnings #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f4014d
Enabled more compiler warnings
jose-luis-rs Feb 18, 2023
ba8f4b4
Update
jose-luis-rs Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ check_compiler()
if(DEFINED ENV{WERROR} AND "$ENV{WERROR}")
message(STATUS "Will compile with -Werror. ")
set(CMAKE_CXX_FLAGS
"${CMAKE_CXX_FLAGS} -Wall -Wformat-security -Werror -Wno-sign-compare -Wno-reorder -Wno-unused-variable -Wno-unused-but-set-variable -Wfatal-errors"
"${CMAKE_CXX_FLAGS} -Wall -Wno-non-virtual-dtor -Wwrite-strings -Wpointer-arith -Wshadow -Wformat-security -Werror -Wno-sign-compare -Wno-reorder -Wno-unused-variable -Wno-unused-but-set-variable -Wfatal-errors"
)
else()
if(NOT APPLE)
Expand All @@ -331,7 +331,7 @@ else()
"Set env WERROR to 1 to enable -Werror. If origin/dev compiles on your platform with that option, it is definitly a good idea to do that."
)
set(CMAKE_CXX_FLAGS
"${CMAKE_CXX_FLAGS} -Wall -Wformat-security -Wno-sign-compare -Wno-reorder -Wno-unused-variable -Wno-unused-but-set-variable"
"${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-ignored-qualifiers -Wfatal-errors -Wno-vla -Wwrite-strings -Woverloaded-virtual -Wshadow -Wformat-security -Wno-sign-compare -Wno-reorder"
)
endif()
endif()
Expand Down
1 change: 0 additions & 1 deletion los/calib/R3BLosCal2Hit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ class R3BLosCal2Hit : public FairTask
TH2F* fhQ3_vs_Q7_corr;
TH2F* fhQ4_vs_Q8;
TH2F* fhQ4_vs_Q8_corr;
;
TH2F* fhTresX_M;
TH2F* fhTresY_M;
TH2F* fhTresX_T;
Expand Down
Loading