Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_size check results in error #205

Closed
JosiahParry opened this issue Jul 12, 2024 · 0 comments
Closed

page_size check results in error #205

JosiahParry opened this issue Jul 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JosiahParry
Copy link
Collaborator

Repro based on :R-ArcGIS/arcpbf#2

library(arcgislayers)

PRCP_pred <- "https://services.arcgis.com/GL0fWlNkwysZaKeV/arcgis/rest/services/TXLA_ZCTA_PRCPpred/FeatureServer/0" |> 
    arc_open() -> x

res <- x |> 
    arc_select(n_max = 500, page_size = 10)

We need to 1 fix this and 2 add tests.

There is some wonkiness with the rlang standalone checks that break the check

here is the workaround code

  check_number_whole(as.integer(page_size), min = 1, allow_null = TRUE)
  check_number_whole(
    as.integer(page_size),
    max = as.double(x$maxRecordCount),
    allow_null = TRUE
  )
@JosiahParry JosiahParry added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant