Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined or null as projection child #7376

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Feb 24, 2025

No description provided.

@Varixo Varixo self-assigned this Feb 24, 2025
@Varixo Varixo requested a review from a team as a code owner February 24, 2025 15:08
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 976e636

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo linked an issue Feb 24, 2025 that may be closed by this pull request
@Varixo Varixo marked this pull request as draft February 24, 2025 16:11
@Varixo Varixo force-pushed the v2-null-undefined-proj branch from 843093e to fdc6de1 Compare February 24, 2025 19:48
Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7376
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7376
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7376
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7376

commit: 976e636

@Varixo Varixo force-pushed the v2-null-undefined-proj branch from fdc6de1 to 976e636 Compare February 24, 2025 20:04
@Varixo Varixo marked this pull request as ready for review February 24, 2025 20:13
Copy link
Contributor

github-actions bot commented Feb 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 976e636

@devcaeg
Copy link

devcaeg commented Feb 24, 2025

If I am not mistaken, this PR also solves issue #7373

I must do more tests to confirm this.

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmertens wmertens merged commit 854f95b into build/v2 Feb 25, 2025
19 checks passed
@wmertens wmertens deleted the v2-null-undefined-proj branch February 25, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] v2 playground in dev mode hides component$
3 participants