Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): performance improvements #7346

Merged
merged 6 commits into from
Feb 18, 2025
Merged

fix(core): performance improvements #7346

merged 6 commits into from
Feb 18, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Feb 16, 2025

Speed up CSR rendering.
For 10k interactive components down from 600ms to 250ms.

  • rewrite cleaning up subscriptions
  • use for of instead of foreach
  • change a little bit VNodes structure for props
    before:
[
 flags,
 parent,
 siblings,
 etc,
 prop1Key, prop1Value, prop2Key, prop2Value
]

after:

[
 flags,
 parent,
 siblings,
 etc,
 [prop1Key, prop1Value, prop2Key, prop2Value] //<--inner array
]
  • reuse existing subscription for signals and stores

Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: d8740b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7346
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7346
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7346
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7346

commit: d8740b6

Copy link
Contributor

github-actions bot commented Feb 16, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d8740b6

@Varixo Varixo marked this pull request as ready for review February 18, 2025 19:03
@Varixo Varixo requested a review from a team as a code owner February 18, 2025 19:03
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM let's gooooo

@wmertens wmertens merged commit f75c875 into build/v2 Feb 18, 2025
19 checks passed
@wmertens wmertens deleted the v2-perf-improv branch February 18, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants