Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qwik): export build constants from core #7138

Merged
merged 3 commits into from
Dec 9, 2024
Merged

feat(qwik): export build constants from core #7138

merged 3 commits into from
Dec 9, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Dec 7, 2024

my xmas gift for @thejackshelton ;)

this allows using `changeset add` when you don't have the `upcoming` branch locally, and it also prevents it being stale.
@wmertens wmertens requested review from a team as code owners December 7, 2024 08:37
Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: 5eb90ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 7, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7138
npm i https://pkg.pr.new/@builder.io/qwik-city@7138
npm i https://pkg.pr.new/eslint-plugin-qwik@7138
npm i https://pkg.pr.new/create-qwik@7138

commit: 4668e82

Copy link
Contributor

github-actions bot commented Dec 7, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 4668e82

@thejackshelton
Copy link
Member

christmas

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @wmertens !

@wmertens wmertens merged commit d31ee31 into main Dec 9, 2024
21 checks passed
@wmertens wmertens deleted the const-in-core branch December 9, 2024 00:45
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants