Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QwikDev/qwik
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e0c5474517cdf51bafd1e992db062e19e434dd27
Choose a base ref
..
head repository: QwikDev/qwik
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 095bcb3529324ae0c31d200039c248cc2f9ac46c
Choose a head ref
Showing with 20 additions and 17 deletions.
  1. +5 −0 .changeset/wicked-foxes-behave.md
  2. +5 −5 package.json
  3. +1 −1 packages/docs/src/repl/worker/app-bundle-client.ts
  4. +3 −10 packages/docs/src/root.tsx
  5. +6 −1 starters/apps/library/vite.config.ts
5 changes: 5 additions & 0 deletions .changeset/wicked-foxes-behave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-qwik': patch
---

feat: added `preserveModules` to library starters to improve library bundling / tree-shaking
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -73,9 +73,6 @@
]
}
},
"simple-git-hooks": {
"pre-commit": "pnpm pretty-quick --staged"
},
"contributors": [
{
"name": "Miško Hevery",
@@ -228,13 +225,13 @@
"lint.prettier": "prettier --cache --check .",
"lint.rust": "make lint",
"lint.syncpack": "syncpack list-mismatches",
"prepare": "simple-git-hooks",
"preinstall": "npx only-allow pnpm",
"prepare": "simple-git-hooks",
"prettier.fix": "prettier --cache --write .",
"qwik-save-artifacts": "tsm ./scripts/qwik-save-artifacts.ts",
"release": "changeset publish",
"release.prepare": "pnpm build --prepare-release",
"release.pkg-pr-new": "pnpm dlx pkg-pr-new@^0.0.9 publish --compact --pnpm ./packages/qwik ./packages/qwik-city ./packages/eslint-plugin-qwik ./packages/create-qwik",
"release.prepare": "pnpm build --prepare-release",
"serve": "tsm --inspect --conditions=development starters/dev-server.ts 3300",
"serve.debug": "tsm --inspect-brk --conditions=development starters/dev-server.ts 3300",
"start": "concurrently \"npm:build.watch\" \"npm:tsc.watch\" -n build,tsc -c green,cyan",
@@ -256,5 +253,8 @@
"update.qwik.builds": "tsm scripts/update-qwik-builds.ts packages/docs && tsm scripts/update-qwik-builds.ts packages/insights; pnpm install",
"vitest": "vitest"
},
"simple-git-hooks": {
"pre-commit": "pnpm pretty-quick --staged"
},
"type": "module"
}
2 changes: 1 addition & 1 deletion packages/docs/src/repl/worker/app-bundle-client.ts
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ export const appBundleClient = async (
debug: options.debug,
srcInputs: getInputs(options),
// Older versions don't support `segment`
entryStrategy: options.entryStrategy === 'segment' ? 'hook':options.entryStrategy,
entryStrategy: options.entryStrategy === 'segment' ? 'hook' : options.entryStrategy,
manifestOutput: (m) => {
result.manifest = m;
},
13 changes: 3 additions & 10 deletions packages/docs/src/root.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import {
PrefetchGraph,
PrefetchServiceWorker,
component$,
useContextProvider,
useStore,
} from '@builder.io/qwik';
import { QwikCityProvider, RouterOutlet } from '@builder.io/qwik-city';
import { component$, useContextProvider, useStore } from '@builder.io/qwik';
import { QwikCityProvider, RouterOutlet, ServiceWorkerRegister } from '@builder.io/qwik-city';
import RealMetricsOptimization from './components/real-metrics-optimization/real-metrics-optimization';
import { RouterHead } from './components/router-head/router-head';
import { GlobalStore, type SiteStore } from './context';
@@ -60,8 +54,7 @@ export default component$(() => {
<meta charset="utf-8" />
<script dangerouslySetInnerHTML={uwu} />
<RouterHead />
<PrefetchServiceWorker />
<PrefetchGraph />
<ServiceWorkerRegister />
{/* <script dangerouslySetInnerHTML={`(${collectSymbols})()`} /> */}
<Insights publicApiKey={import.meta.env.PUBLIC_QWIK_INSIGHTS_KEY} />
</head>
7 changes: 6 additions & 1 deletion starters/apps/library/vite.config.ts
Original file line number Diff line number Diff line change
@@ -14,9 +14,14 @@ export default defineConfig(() => {
lib: {
entry: "./src/index.ts",
formats: ["es", "cjs"],
fileName: (format) => `index.qwik.${format === "es" ? "mjs" : "cjs"}`,
fileName: (format, entryName) =>
`${entryName}.qwik.${format === "es" ? "mjs" : "cjs"}`,
},
rollupOptions: {
output: {
preserveModules: true,
preserveModulesRoot: "src",
},
// externalize deps that shouldn't be bundled into the library
external: [
/^node:.*/,