Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to change LOCALE_COOKIE constant #305

Open
ricardo-fnd opened this issue Dec 15, 2023 · 4 comments · May be fixed by #360
Open

Possibility to change LOCALE_COOKIE constant #305

ricardo-fnd opened this issue Dec 15, 2023 · 4 comments · May be fixed by #360
Labels
enhancement New feature or request

Comments

@ricardo-fnd
Copy link

ricardo-fnd commented Dec 15, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
I have a monorepo with some frontend apps. This apps are looking for a NEXT_LOCALE cookie when looking for currentLang.
Now I'm integrating one of the apps (website) to use next-international.

For the other apps to continue working, I will need to change the cookie name in all apps to Next-locale and I'll need also a migration, so users with NEXT_LOCALE cookie won't be affected by this. I'll need to copy NEXT_LOCALE content to Next-locale cookie in all apps.

Describe the solution you'd like
We should be able to change LOCALE_COOKIE constant. createI18nMiddleware should probably accept this argument.
@ricardo-fnd ricardo-fnd added the enhancement New feature or request label Dec 15, 2023
@QuiiBz
Copy link
Owner

QuiiBz commented Dec 20, 2023

Let's add this option in the next release!

@valentinpolitov valentinpolitov linked a pull request Feb 17, 2024 that will close this issue
Open
@ricardo-fnd
Copy link
Author

@QuiiBz any news? :)

@ricardo-fnd
Copy link
Author

@QuiiBz any news? :)

@YusufcanY
Copy link

YusufcanY commented Oct 9, 2024 •
edited
Loading

@QuiiBz any news? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(next-international): added cookieName and headerName options valentinpolitov/next-international
3 participants
@QuiiBz @ricardo-fnd @YusufcanY