Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide opponent points #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hide opponent points #29

wants to merge 2 commits into from

Conversation

akriese
Copy link
Collaborator

@akriese akriese commented Nov 18, 2022 •
edited
Loading

Resolves #15. Game.getScoreAsString() hides functionality.
Also GamePlayer was made private to game.dart, as it is not used anywhere else explicitly.

@akriese
function to build a game score string
d62515d
@akriese
make GamePlayer module-private
1ca1966 
it should only to be used (instantiated) by Game itself
@akriese
Copy link
Collaborator Author

akriese commented Nov 18, 2022

image

@akriese akriese requested a review from simonsasse November 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsasse simonsasse Awaiting requested review from simonsasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Show opponent's points just after one has played the round.
1 participant
@akriese