Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications from xfce4-notifyd in a VM have normal decorations #8181

Closed
marmarek opened this issue May 7, 2023 · 25 comments · Fixed by QubesOS/qubes-core-agent-linux#434
Closed

Notifications from xfce4-notifyd in a VM have normal decorations #8181

marmarek opened this issue May 7, 2023 · 25 comments · Fixed by QubesOS/qubes-core-agent-linux#434
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: Fedora C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-cur-test r4.1-fc36-stable r4.1-fc37-stable r4.1-fc38-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc36-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable
Milestone
Release 4.1 updates

Comments

@marmarek
Copy link
Member

marmarek commented May 7, 2023 •
edited
Loading

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

The notification lacks override-redirect flag, so the window has normal decorations, and also grabs focus.
https://openqa.qubes-os.org/tests/72214/video?filename=video.ogv&t=434.00

Steps to reproduce

  1. Install fedora-38-xfce template.
  2. Create and an AppVM based on it.
  3. Execute notify-send test

Expected behavior

Normal notification, not grabbing the focus.

Actual behavior

A notification window with fully-decorations shows up, and depending on window manager settings, it grabs focus too.

Part of #8069.
This is not the case for Fedora 37 template.
@marmarek marmarek added T: bug C: gui-virtualization P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 7, 2023
@marmarek marmarek added this to the Release 4.2 milestone May 7, 2023
@marmarek marmarek added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label May 7, 2023
@Geblaat
Copy link

Geblaat commented May 29, 2023

I just noticed this in the standard Fedora 38 template on R4.1

@marmarek marmarek added P: major Priority: major. Between "default" and "critical" in severity. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 30, 2023
@marmarek
Copy link
Member Author

Do you see any errors in /var/log/qubes/guid.NAME.log in dom0 (with NAME replaced with the actual qube name)?

@rustybird
Copy link

rustybird commented May 31, 2023 •
edited
Loading

xfce4-notifyd 0.8.0+ (fc38 has 0.8.2) stopped enabling override-redirect on notification windows by default. It's now relying on _MOTIF_WM_HINTS* to tell the window manager not to decorate the window. But 0.8.1+ added a hidden setting to re-enable override-redirect.

* via gtk_window_set_decorated(..., FALSE)

@rustybird
Copy link

rustybird commented May 31, 2023 •
edited
Loading

No idea what's up with the input focus stealing though. Plain old WM_HINTS is declaring that the notification window doesn't want input focus, and the GUI protocol should already be able to forward that information.

@marmarek
Copy link
Member Author

Thanks @rustybird for finding this out! I guess we simply need to enable this setting, the gui daemon already has specific provision to not put any window above the screenlocker.

@marmarek marmarek mentioned this issue Jun 1, 2023
Merged
This was referenced Jun 2, 2023
Closed
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.1.42-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.1 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. labels Aug 8, 2023
@marmarek marmarek removed the backport pending On closed issues, indicates fix released for newer version will be backported to older version. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: Fedora C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-cur-test r4.1-fc36-stable r4.1-fc37-stable r4.1-fc38-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc36-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable
Projects
None yet
Milestone
Release 4.1 updates
Development

Successfully merging a pull request may close this issue.

(Re-)enable override-redirect windows in xfce4-notifyd marmarek/qubes-core-agent-linux
6 participants
@verygreen @marmarek @rustybird @andrewdavidwong @Geblaat @qubesos-bot