Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4.1 ubuntu (bionic) build error for gui-agent-linux (pulseaudio module) #5766

Closed
xychelsea opened this issue Apr 12, 2020 · 7 comments
Closed

Comments

@xychelsea
Copy link

xychelsea commented Apr 12, 2020

Qubes OS version
R4.1

Affected component(s) or functionality
qubes-gui-agent-linux

Brief summary
qubes-builder fails to build pulseaudio module (module-vchan-sink) in qubes-gui-agent-linux for ubuntu (bionic) using builder-debian

make -C pulse module-vchan-sink.so
make[3]: Entering directory '/home/user/qubes-src/gui-agent-linux/pulse'
gcc -Wall -Wextra -Werror -O2 -g -c `pkg-config --cflags vchan-xen` -fPIC module-vchan-sink.c  -DHAVE_CONFIG_H -I.
module-vchan-sink.c: In function 'module_vchan_sink_LTX_pa__init':
module-vchan-sink.c:737:27: error: format not a string literal and no format arguments [-Werror=format-security]
                           DEFAULT_SINK_DESC));
                           ^~~~~~~~~~~~~~~~~
module-vchan-sink.c:779:25: error: format not a string literal and no format arguments [-Werror=format-security]
                         pa_modargs_get_value(ma, "source_desc", DEFAULT_SOURCE_DESC));
                         ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

To Reproduce
qubes-builder downloads all master repositories and gets sources, meanwhile build.conf has bionic added as a vm template

make qubes-vm

or

make gui-agent-linux

Expected behavior
normal pulseaudio module build for gui-agent-linux, ubuntu (bionic) template

Actual behavior
build error with specific gcc errors

gui-agent-linux-vm-bionic.log

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
version 4.1.7 of gui-agent-linux and all other components of qubes-builder are QubesOS master repositories

Solutions you've tried
building earlier versions (v4.1.1) of qubes-agent-gui-linux but creates a tree of dependency issues with other (qubes-gui-daemon for instance) components

Relevant documentation you've consulted
github readmes and documentation for qubes-builder, qubes-gui-agent-linux, etc.

Related, non-duplicate issues
None

@xychelsea xychelsea added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Apr 12, 2020
@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone Apr 12, 2020
@xychelsea
Copy link
Author

xychelsea commented Apr 13, 2020

component builds successfully on ubuntu (bionic) build with patch

marmarek added a commit to QubesOS/qubes-gui-agent-linux that referenced this issue Apr 18, 2020
pa_proplist_setf should be used only with an actual format string,
otherwise pa_proplist_sets should be used. If the value doesn't contain
any %-sequence, the result is the same, but gcc -Werror=format-security
complains about format string being non-literal. This is the case for
Ubuntu bionic build.

Change it to pa_proplist_sets.

Fixes QubesOS/qubes-issues#5766

(cherry picked from commit b9ccb2f)
@qubesos-bot
Copy link

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-agent_4.0.28-1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-agent_4.0.29-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.1 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-agent_4.1.8-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants