-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Updater" Iconography #5657
Comments
We use similar icon for "restart vm to apply changes made in the template" already. Which BTW I think you confused here - those vms are not templates. so they don't have updates to be applied - only templates (and standalone vms) do. Also, we don't really keep information "how many updates are there", only "which templates needs to be updated" (aggregated into "Updates available for X qubes" in the widget). Do you think number of updates to be applied in a single template is something meaningful for the user? |
It isn't. It's the type of update that's important and you cant parse that. |
Actually, you can. At least repository metadata in Fedora contains this information. You can extract it for example with:
There are probably more ways to do that too. In any case, we currently don't extract this information, so adding it would be more work than just changing the icon. |
As @marmarek said - currently a similar icon is used for "needs restarting". I wonder if this won't be confusing to the user (or how should we change the 'needs restarting icon' to communicate consistently with this). I love how the widget icon looks like! |
Aaaaah.... see, I did not know that's what the existing icon meant. I'd thought it meant that things need to be downloaded, installed, and then the thing restarted. WRT the shown numeral as a signifier of something... what matters to the user, is "How long will all of this take, what things need to shut-down, and when can I get back to doing my business?" If the current integer that is tracked is the number of templates in need of updating, that works plenty well! Thank you for the helpful clarification, @marmarek. Ok, I need to go and re-think all of this, now that I think I understand it all better. More, later! :) |
While we're on the clarification-train @marmarta... what do the grayed-out icons mean, next to my disp-VMs? |
Normally it means the template it is based on is running and you'll need to restart the VM after the template is powered off. And indeed |
@marmarek , do they make sense for persistent/named dispvms? should I make a new ticket to remove them in all dispvm cases? |
Yes, they do make sense for named dispvms. |
@ninavizz , I think the best answer to your question is: they should not be there at all and won't be in the future releases |
@marmarta My brain was just starting to meander in that direction. :) So, is the consenssus then, that Qube Manager should just not show any restart-y/updater-y type icons? If "no," then what signifiers/actions would bring value to users in the existing Qube Manager design? Not in the scope of this question, of course, wd be all the awesome ways in which a dreamworld's Qube Manager could function. Just working within today's framework. |
okay, so, I've had a look in the code, realized what I forgotten about it, and here's the current state:
The discussion above occurred because we shouldn't be showing either of those for DispVMs - but for other VMs they are still needed. I'm not that sure the grey icon adds that much, but I may overlook why this is an important information. |
The second bullet feels very confusing. Like, really confusing. Can these icons get tooltips? I'll mull over what more relevant semiotics or other visual cues, there might be. There is a point of diminishing returns on "Too Much Information," and what a user can meaningfully act upon or otherwise needs to know to understand why things may or may not be working as desired, wd be helpful to understand. Also questioning the value of communicating all this updating information to users so piecemeal, vs in a more unified fashion—tho I suspect its because of how uniquely segmented Qubes is, from other systems... and that this is one of those "Qubes introduces its own paradigms" things. |
AFAIR the main reason for this gray "will need restart after template shutdown" icon is to remind users that changes made in the template that is still running are not applied yet. And it actually has a tooltip already: "The Template must be stopped before changes from its current session can be picked up by this qube." |
Bigger question: why the green icons at all? If a Qube is not running, but changes will take effect when it runs next time—why does the user need to know this? To know that they'll be delayed in using that Qube next time they go to run it, because updates have to be applied? Is there a reason to let users know a Template has been updated and that descendant Qubes will only be updated once they restart again? Is there risk in letting a descendant Qube remain outdated for a long time on a user's machine? The grey icons, otoh, do seem to have a clear value: "Hey, changes need to be applied, you should quit and restart this VM when you can." Or something. |
Hm? I don't think there is a case where this green icon is visible next to a stopped qube. Did you get such case?
Yes, until you restart your qube, it won't use updates applied in the template. This may mean for example you're running a web browser with known vulnerability (that is already patched in the template).
I think you confused grey and green icons here. This is what green arrows icon means. The main difference between green and grey variant is whether the template is still running. If it is (grey icon), you first need to shutdown the template - which will make the icon green. Then, green icon means you need to restart the qube marked with this green icon. |
Something I finally figured-out this AM while working in Qubes: clicking on the green icons, does nothing. Traditionally, a green icon w/in a UI means "click on this to make the implied action happen." In the open-domains menu (from the Tray) it's more confusing, that "Restart" isn't an option—when the point of the icon is to tell the user that they should restart a Qube so updates can be applied. Ok, I guess this Issue began as a little idea of mine to address one icon that seemed confusing, and also had some related icons that could use updating... and devolved into a thread about how required and pending updates are communicated to users? All good stuff to work on—but clearly more of a design inquiry issue, than a solution ready to implement. :) |
So, recap; there are two visual elements; That second element can have several states, depending on the type of qube involved.. Perhaps this should be added to #5679 ; make the sorting work different; instead of sorting on columns, sort outside of that display-area, with another control (a dropdown or buttons). That would also enable the option to change a property of a VM by using drag and drop. So, I'd sort on template, the list would show the VM's grouped "underneath" a template. my-personal-template my-personal-mail my-personal-browsing my-work-template my-work-mail my-work-browsing I could then drag 'my-work-browsing' underneath 'my-personal-template', to change the template property of that VM. The same goes for other properties, network, colour. Of course there are restrictions, just like there are when you right-click on a VM and open 'Qube Settings'. |
Ayy, just now noticing this is slated for the 4.1 release. @marmarta What part of this exactly, is desired to be included in the release? I recently Had Thoughts about the green-circle-arrows icons being used in the context of menus (signifying the VM needs to be restarted). In all the contexts I've looked at since I created this issue, typically the icon signifying that is a triangle/caution-bang, or a circle-bang; not the circley-green icon. I'd love to get an update to this whole family of icons (things pertaining to updates) in 4.1, and don't want this to fall off the radar. Perhaps discuss this upcoming Monday in a Qubes UX Things call? |
sounds good to me! |
I think one useful approach might be to segment dispvms into their own tab of the manager UI. They are actually quite different from other qubes in a lot of ways, many of them subtle and with potential security implications. I think the selection of what indicators are appropriate should maybe be done somewhat from scratch per category:
|
Noting here: A few requests in the AppMenu survey, to let users know when there are, specifically, security updates that need to be run. Re-reading through this Issue a year later is wonderful. I'd totally forgotten about Marek citing the four different types of updates that exist. Also, this issue currently has a |
Moved to |
@marmarek FYI, I still cannot change the release milestone in the web UI here, nor add cards to the Updater project. Only an FYI, as I know you have bigger fish to fry, Marek! Thx @DemiMarie !! |
You need to accept the invitation |
You’re welcome! |
Problem
A simpler family of icons needs to exist, so that between the Tray, the Open Domains menu, and the Qube Manager, updater things can be more clearly communicated to and acted upon by users.
Solution
Working solution, open to further exploration
Cross-referencing as part of proposed EPIC #5520
The text was updated successfully, but these errors were encountered: