Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsa-4371 fix and new debian versions #5150

Closed
xaki23 opened this issue Jul 7, 2019 · 3 comments
Closed

dsa-4371 fix and new debian versions #5150

xaki23 opened this issue Jul 7, 2019 · 3 comments
Labels
C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix P: default Priority: default. Default priority for new issues, to be replaced given sufficient information.

Comments

@xaki23
Copy link

xaki23 commented Jul 7, 2019

Qubes OS version
R4.0

Affected component(s) or functionality
qubes-manager rightclick-update

Brief summary
new debian_versions currently have to be added to the 4371-check by and, one by one.
this leads to kali, whonix, debian not being updateable through QM for days/weeks

To Reproduce

  1. install whonix-15
  2. rightclick-update whonix15 in qubes-manager
  3. see "unknown debian version" error.

Expected behavior
working updates

Actual behavior
useless error

Screenshots
n/a

Comment
i suggest to remove dsa-4371-update at this point or at least make the *) case non-fatal.
new debians appearing at this point probably can be assumed to have the fix already.
and if you are still running some pre-2019 version of debian and didnt update it in the last half year 4371 probably isnt your biggest problem.

@xaki23 xaki23 added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Jul 7, 2019
@andrewdavidwong andrewdavidwong added C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix labels Jul 8, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Jul 8, 2019
@lunarthegrey
Copy link

I think this is a duplicate of #5057

@xaki23
Copy link
Author

xaki23 commented Jul 9, 2019

I think this is a duplicate of #5057

sortof.
#5057 shows the problem of the current situation (where every potential vaguely debian based future distro has to be added to that matching in dom0)

i opened this one because it seems quite possible that any future debian variants will not ship with dsa-4371 affected userland.
so perhaps we should call off adjusting a workaround for a fix that is now ... probably fixed in all the places that matter.

and if someone now, lets say, installs a fresh legacy q4.0 with an affected debian-9 ... if they update their deb-9 before ( updating dom0 and restarting qubes-manager ) ... they are not getting the fix-check anyways.

@marmarek
is making the else-branch in the version matcher non-fatal ok with you at this point?
or rather wait for q4.0.2? (aka "no longer shipping an installer that could be affected")

@xaki23
Copy link
Author

xaki23 commented Dec 23, 2019

closing because fix merged long ago.

a similar issue still exists with
/srv/formulas/base/update-formula/update/dsa-4371-update
from pkg qubes-mgmt-salt-dom0-update

@xaki23 xaki23 closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix P: default Priority: default. Default priority for new issues, to be replaced given sufficient information.
Projects
None yet
Development

No branches or pull requests

3 participants