Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in window titles do not render #1059

Closed
bnvk opened this issue Jul 12, 2015 · 17 comments
Closed

Special characters in window titles do not render #1059

bnvk opened this issue Jul 12, 2015 · 17 comments
Labels
C: gui-virtualization help wanted This issue will probably not get done in a timely fashion without help from community contributors. localization This issue concerns translating things into different languages or adapting them to other regions. P: minor Priority: minor. The lowest priority, below "default." security This issue pertains to the security of Qubes OS. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience

Comments

@bnvk
Copy link

bnvk commented Jul 12, 2015

I am noticing in both the main AppVM color coded border as well as in the panel bar of the desktop, that special characters like ö í á ð Þ ý from Icelandic as well as more normal special chars like quote " char render instead as underscores __ see attached screenshot

special chars in window titles

@marmarek
Copy link
Member

Take a look at guid configuration, especially allow_utf8_titles.
@rootkovska, maybe we should enable it by default?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@bnvk
Copy link
Author

bnvk commented Jul 13, 2015

@marmarek thanks for the suggestion. I edited those config items and restarted my VMs and then my whole machine, but the issue still persists.

I think enabling utf8 tittles by default would be a significant user experience improvement. In general, asking a user to edit a config file in a CLI is something rather advanced subset of users. cc: @rootkovska

@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: gui-virtualization P: major Priority: major. Between "default" and "critical" in severity. labels Jul 18, 2015
@marmarek marmarek added this to the Release 3.0 milestone Jul 18, 2015
@rootkovska
Copy link
Member

The reason we filter out utf8 from titlebar is for extra security. Given that we currently (3.0) don't support international versions that well anyway, I suggest we leave the default off, and moving this ticker to 3.1 for further considerations.

@rootkovska rootkovska modified the milestones: Release 3.1, Release 3.0 Sep 2, 2015
@mfc
Copy link
Member

mfc commented Nov 19, 2015

can someone add a "localization" tag to this issue? and any others that impact non-english-speaking users.

at minimum this should be an option during first installation for the user to select, and let them know what they gain/lose.

@marmarek marmarek added the localization This issue concerns translating things into different languages or adapting them to other regions. label Nov 25, 2015
@rootkovska rootkovska modified the milestones: Release 4.0, Release 3.1 Feb 12, 2016
@rootkovska rootkovska added P: minor Priority: minor. The lowest priority, below "default." ux User experience and removed P: major Priority: major. Between "default" and "critical" in severity. labels Feb 12, 2016
@rootkovska
Copy link
Member

We would like to have this as a default setting applied by Firstboot, allowing the (more advanced) user to untick it.

@mfc
Copy link
Member

mfc commented Feb 12, 2016

could this in the meantime be a setting in the Qubes VM Manager? I don't know if that would make it faster to implement.

@rootkovska rootkovska modified the milestones: Release 3.2, Release 4.0 Feb 12, 2016
@rootkovska rootkovska added the help wanted This issue will probably not get done in a timely fashion without help from community contributors. label Feb 12, 2016
@bnvk bnvk mentioned this issue Feb 18, 2016
20 tasks
@ThomasWaldmann
Copy link

borgbase/vorta#144 looks like i just stumbled over this in qubes 4.0.1.

@iamahuman
Copy link

Concrete suggestion: allow specifying Unicode codepoint ranges.

@marmarek
Copy link
Member

Do you have any suggestions for specific sensible values to choose from? It would make sense to propose few examples for various regions.

@iamahuman
Copy link

iamahuman commented Jun 27, 2020

@marmarek The simplest (sounding) option is to just let the user decide (they can already kill off utf8 filtering entirely).

Allowing non-combining characters (ISO-8859-1 already has precomposed characters) shall make sense as a default.

The ideal way to derive a decision is perhaps to study the code paths of Unicode rendering libraries. If it turns out we don't have much time for this, we can just rip off some ranges from the Unicode database or something.

@iamahuman
Copy link

Ah, I think I've misunderstood what you've said. I'll research into it when I have more free time.

@CrsiX
Copy link

CrsiX commented Jan 9, 2021

I know this is a pretty old issue but I stumbled over it after my first installation. The fix was applied quickly though.

However, I just want to ask where's the problem with UTF8 titles? I heard security as the argument (which is totally fine for a security-oriented OS), but could someone point out how UTF8 titles decrease VM or system security? I found this pretty long report, but I don't see the point. In case it was somehow, even in theory, insecure to use UTF8 titles, all major desktop environments/window managers or X11/Wayland would have taken countermeasures, wouldn't they? And AFAICT the characters in the title are just shown and not interpreted or executed.

@iamahuman
Copy link

@CrsiX It's because Unicode is quite complex: https://appleinsider.com/articles/18/05/09/black-dot-unicode-bug-crashes-ios-messages-app-using-invisible-characters

Hence the proposal to allow only specific range of codepoints.

@CrsiX
Copy link

CrsiX commented Jan 10, 2021

@iamahuman Well, I heart about those issues and I see the point. However, I don't really expect crashes or even security holes from using UTF8 titles (while being possible of course). I mean, I've used them in my prior OSes all the time. So, for me, enabling it is totally fine. :D
Anyways, there's no known attack on window titles, is it? ;)

@DemiMarie
Copy link

@iamahuman Well, I heart about those issues and I see the point. However, I don't really expect crashes or even security holes from using UTF8 titles (while being possible of course). I mean, I've used them in my prior OSes all the time. So, for me, enabling it is totally fine. :D
Anyways, there's no known attack on window titles, is it? ;)

There was an exploitable vulnerability in fribidi that allowed displaying valid UTF-8 to cause code execution a while back. So there is precedent.

@andrewdavidwong andrewdavidwong added the security This issue pertains to the security of Qubes OS. label Jan 11, 2021
@marmarek
Copy link
Member

marmarek commented Feb 6, 2022

In R4.1: the setting can be changed in VM settings now.

@mfc
Copy link
Member

mfc commented Feb 20, 2022

In R4.1: the setting can be changed in VM settings now.

super! closing.

@mfc mfc closed this as completed Feb 20, 2022
@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gui-virtualization help wanted This issue will probably not get done in a timely fashion without help from community contributors. localization This issue concerns translating things into different languages or adapting them to other regions. P: minor Priority: minor. The lowest priority, below "default." security This issue pertains to the security of Qubes OS. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience
Projects
None yet
Development

No branches or pull requests

9 participants