Skip to content

Commit

Permalink
Don't cancel updates on Esc
Browse files Browse the repository at this point in the history
Only close updater window on Esc when intro
or summary are visible (where closing the window quickly
can be desirable and has no problematic side-effects)

fixes QubesOS/qubes-issues#8671
  • Loading branch information
marmarta committed May 15, 2024
1 parent 4afc35e commit b73f474
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion qui/updater/updater.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ def cancel_updates(self, *_args, **_kwargs):

def check_escape(self, _widget, event, _data=None):
if event.keyval == Gdk.KEY_Escape:
self.window_close()
if self.intro_page.is_visible or self.summary_page.is_visible:
self.window_close()

Check warning on line 243 in qui/updater/updater.py

View check run for this annotation

Codecov / codecov/patch

qui/updater/updater.py#L242-L243

Added lines #L242 - L243 were not covered by tests

def window_close(self, *_args, **_kwargs):
self.log.debug("Close window")
Expand Down

0 comments on commit b73f474

Please sign in to comment.