Skip to content

Commit

Permalink
vm: drop 'internal' property
Browse files Browse the repository at this point in the history
It isn't used anywhere in the code right now. And when it will be
needed, it should be a "feature" not "property".
  • Loading branch information
marmarek committed Jun 12, 2017
1 parent 206b7c0 commit 9d99232
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
4 changes: 0 additions & 4 deletions qubes/tests/vm/qubesvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,6 @@ def test_171_maxmem_invalid(self):
# TODO: lower than memory
# TODO: human readable setter (500M, 4G)?

def test_180_internal(self):
vm = self.get_vm(label='red')
self._test_generic_bool_property(vm, 'internal', False)

def test_190_vcpus(self):
vm = self.get_vm()
self.assertPropertyDefaultValue(vm, 'vcpus', self.app.host.no_cpus)
Expand Down
7 changes: 1 addition & 6 deletions qubes/vm/qubesvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,6 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
default=None,
doc='Memory ammount allocated for the stubdom')

internal = qubes.property('internal', default=False,
type=bool, setter=qubes.property.bool,
doc='''Internal VM (not shown in qubes-manager, don't create appmenus
entries.''')

vcpus = qubes.property('vcpus',
type=int,
setter=_setter_positive_int,
Expand Down Expand Up @@ -492,7 +487,7 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
dom0 boot.''')

include_in_backups = qubes.property('include_in_backups',
default=(lambda self: not self.internal),
default=True,
type=bool, setter=qubes.property.bool,
doc='If this domain is to be included in default backup.')

Expand Down

0 comments on commit 9d99232

Please sign in to comment.