From 00256e48e9237855fbd88119474a0a3057d3e4dd Mon Sep 17 00:00:00 2001 From: Piotr Bartman Date: Fri, 19 Apr 2024 06:39:24 +0200 Subject: [PATCH] q-dev: typos --- qubes/ext/block.py | 3 ++- qubes/tests/vm/qubesvm.py | 2 +- qubes/vm/qubesvm.py | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qubes/ext/block.py b/qubes/ext/block.py index f1924340c..0e21424fb 100644 --- a/qubes/ext/block.py +++ b/qubes/ext/block.py @@ -511,7 +511,8 @@ def pre_attachment_internal( 'This device can be attached only read-only') if not vm.is_running(): - print("Not attach, not running", file=sys.stderr) + print(f"Can not attach device, qube {vm.name} is not running." + , file=sys.stderr) return if not isinstance(device, BlockDevice): diff --git a/qubes/tests/vm/qubesvm.py b/qubes/tests/vm/qubesvm.py index c1c50b5cb..04c2f7fd3 100644 --- a/qubes/tests/vm/qubesvm.py +++ b/qubes/tests/vm/qubesvm.py @@ -1393,7 +1393,7 @@ def test_600_libvirt_xml_hvm_pcidev_s0ix(self): # even with meminfo-writer enabled, should have memory==maxmem vm.features['service.meminfo-writer'] = True assignment = qubes.device_protocol.DeviceAssignment( - vm, # this is violation of API, but for PCI the argument + vm, # this is a violation of API, but for PCI the argument # is unused '00_00.0', devclass='pci', diff --git a/qubes/vm/qubesvm.py b/qubes/vm/qubesvm.py index 7993e7baa..f604eb0ff 100644 --- a/qubes/vm/qubesvm.py +++ b/qubes/vm/qubesvm.py @@ -1629,9 +1629,9 @@ def is_memory_balancing_possible(self): - have PCI devices - balloon driver not present - We don't have reliable way to detect the second point, but good + We don't have a reliable way to detect the second point, but good heuristic is HVM virt_mode (PV and PVH require OS support, and it does - include balloon driver) and lack of qrexec/meminfo-writer service + include the balloon driver) and lack of qrexec/meminfo-writer service support (no qubes tools installed). """ if list(self.devices['pci'].get_assigned_devices()):