Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qubes update tool: Summary for Fedora templates not alphabetically sorted #9617

Closed
Geblaat opened this issue Dec 1, 2024 · 1 comment · Fixed by QubesOS/qubes-core-admin-linux#173
Closed

Qubes update tool: Summary for Fedora templates not alphabetically sorted #9617

Geblaat opened this issue Dec 1, 2024 · 1 comment · Fixed by QubesOS/qubes-core-admin-linux#173
Assignees
@alimirjamali
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@Geblaat
Copy link

Geblaat commented Dec 1, 2024

How to file a helpful issue

Qubes OS release

R4.2.3

Brief summary

When using Qubes Update tool with Fedora based templates, the summary at the end with list of updated/installed packages is not in alphabetical order, which makes it harder to read and see what is updated. When running DNF inside the template instead of using Qubes Update, the order is alphabetical, so this seems to be a bug in Qubes Update.
In addition to that, Qubes update does show the updated packages in alphabetical order for Debian based templates.

Steps to reproduce

Use Qubes Update tool to update Fedora based templates

Expected behavior

Summary at the end with list of updated/installed packages should be listed in alphabetical order to make it easier to glance through and see what is updated.

Actual behavior

The list is not in alphabetical order.
@Geblaat Geblaat added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Dec 1, 2024
@alimirjamali
Copy link

Observation:

Update summary of both GUI & CLI updaters for all Distros/Package managers is printed via _print_changes function of PackageManager class of the core-admin-linux vmupdate. Sorting installed, updated and removed packages is harmless and easy. I will do it and test it for few updates and submit the PR.

@alimirjamali alimirjamali mentioned this issue Dec 1, 2024
Merged
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. C: updates affects-4.2 This issue affects Qubes OS 4.2. labels Dec 3, 2024
marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue Dec 17, 2024
@marmarek
Merge remote-tracking branch 'origin/pr/173'
aa27f80 
* origin/pr/173:
  Sort list of updated, installed & removed packages

Pull request description:

resolves: QubesOS/qubes-issues#9617

also adding missing docstrings to make pylint happier
@qubesos-bot qubesos-bot mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
affects-4.2 This issue affects Qubes OS 4.2. C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort list of updated, installed & removed packages alimirjamali/qubes-core-admin-linux
3 participants
@alimirjamali @andrewdavidwong @Geblaat