Sort list of updated, installed & removed packages

resolves: QubesOS/qubes-issues#9617 also adding missing docstrings to make pylint happier
QubesOS · Dec 1, 2024 · ef1b36a · ef1b36a
1 parent 79756e7
commit ef1b36a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/vmupdate/agent/source/common/package_manager.py b/vmupdate/agent/source/common/package_manager.py
@@ -18,6 +18,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301,
 # USA.
+""" package manager for VMs """
 import io
 import logging
 import subprocess
@@ -28,6 +29,7 @@
 
 
 class PackageManager:
+    """ main package manager class """
     def __init__(self, log_handler, log_level):
         self.package_manager: Optional[str] = None
         self.log = logging.getLogger(
@@ -216,15 +218,15 @@ def _print_changes(self, changes):
         result = ProcessResult()
         result.out += self._print_to_string("Installed packages:")
         if changes["installed"]:
-            for pkg in changes["installed"]:
+            for pkg in sorted(changes["installed"]):
                 result.out += self._print_to_string(
                     pkg, changes["installed"][pkg])
         else:
             result.out += self._print_to_string("None")
 
         result.out += self._print_to_string("Updated packages:")
         if changes["updated"]:
-            for pkg in changes["updated"]:
+            for pkg in sorted(changes["updated"]):
                 result.out += self._print_to_string(
                     pkg,
                     str(changes["updated"][pkg]["old"])[2:-2]
@@ -235,7 +237,7 @@ def _print_changes(self, changes):
 
         result.out += self._print_to_string("Removed packages:")
         if changes["removed"]:
-            for pkg in changes["removed"]:
+            for pkg in sorted(changes["removed"]):
                 result.out += self._print_to_string(
                     pkg, changes["removed"][pkg])
         else: