Do not install man pages and profile.d files as executable

They shouldn't be executable. QubesOS/qubes-issues#6567
QubesOS · Nov 5, 2023 · d257ce8 · d257ce8
1 parent 77cdc17
commit d257ce8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -33,7 +33,7 @@ install-vm-common:
 	install -D gpg-import-key $(DESTDIR)/usr/bin/qubes-gpg-import-key
 	install -D qubes.Gpg.service $(DESTDIR)/etc/qubes-rpc/qubes.Gpg
 	install -D qubes.GpgImportKey.service $(DESTDIR)/etc/qubes-rpc/qubes.GpgImportKey
-	install -D qubes-gpg.sh $(DESTDIR)/etc/profile.d/qubes-gpg.sh
+	install -m 0644 -D qubes-gpg.sh $(DESTDIR)/etc/profile.d/qubes-gpg.sh
 	install -D qubes-gpg-split.tmpfiles $(DESTDIR)/usr/lib/tmpfiles.d/qubes-gpg-split.conf
 	make -C tests install-vm
 	make -C doc install

diff --git a/doc/Makefile b/doc/Makefile
@@ -10,7 +10,7 @@ manpages: $(DOCS)
 
 install: manpages
 	install -d $(DESTDIR)/usr/share/man/man1
-	install -D $(DOCS) $(DESTDIR)/usr/share/man/man1/
+	install -m 0644 -D $(DOCS) $(DESTDIR)/usr/share/man/man1/
 
 %.1: %.rst
 	$(PANDOC) $< > $@