Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully integrate EIP-712 #117

Open
qcdll opened this issue Sep 25, 2018 · 0 comments
Open

fully integrate EIP-712 #117

qcdll opened this issue Sep 25, 2018 · 0 comments
Assignees
@qcdll
Labels
enhancement New feature or request

Comments

@qcdll
Copy link
Contributor

qcdll commented Sep 25, 2018

currently, pyquarkchain's transaction include a field called version which signifies how the transaction is signed:

pyquarkchain/quarkchain/evm/transactions.py

Line 64 in 3648337

('version', big_endian_int),

0 means the signature is generated in a similar way to ethereum transactions
1 means the signature is generated based on typed signature (EIP-712) as implemented by MetaMask BEFORE #4803

after Metamask 4803 is pushed, it will be a breaking change for MetaMask users of our testnet, so we need to upgrade accordingly
@qcdll qcdll added the enhancement New feature or request label Sep 25, 2018
@qcdll qcdll self-assigned this Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qcdll qcdll

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qcdll