Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm type piracy #18

Open
Roger-luo opened this issue May 16, 2019 · 2 comments
Open

rm type piracy #18

Roger-luo opened this issue May 16, 2019 · 2 comments
Labels
bug Something isn't working high priority upstream

Comments

@Roger-luo
Copy link
Member

This package contains a lot workarounds which contains type piracy, need to check if they are in Base already or PR to upstream.
@Roger-luo Roger-luo added bug Something isn't working high priority upstream labels May 16, 2019
@KristofferC
Copy link
Contributor 

WARNING: Method definition (::Type{SparseArrays.SparseMatrixCSC{Tv, Ti} where Ti<:Integer where Tv})(LinearAlgebra.Diagonal{T, V} where V<:AbstractArray{T, 1}) where {T} in module SparseArrays at /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.3/SparseArrays/src/sparsematrix.jl:492 overwritten in module LuxurySparse at /Users/kristoffer/.julia/packages/LuxurySparse/Ggy9Z/src/conversions.jl:23.
  ** incremental compilation may be fatally broken for this module **

for example.

@Roger-luo
Copy link
Member Author

thanks, fixed by ce856f1

@Roger-luo Roger-luo mentioned this issue Sep 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KristofferC @Roger-luo