Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to version 5? #1

Closed
peterzsohar opened this issue Jul 17, 2020 · 1 comment · Fixed by #2
Closed

Upgrade to version 5? #1

peterzsohar opened this issue Jul 17, 2020 · 1 comment · Fixed by #2

Comments

@peterzsohar
Copy link
Member

isort 4.3.21 and black 19.10b0 disagree on whitespace between import lines and comments and there are no settings to make them friends.
It affects 200+ files in our client project 👯

However, isort 5+ comes with a new option "ensure_newline_before_comments" which - in principle - could be used with black.

@xhochy What do you think?
@peterzsohar
Copy link
Member Author

Relevant issue from isort PyCQA/isort#694

@peterzsohar peterzsohar mentioned this issue Jul 17, 2020
Merged
@xhochy xhochy closed this as completed in #2 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update version to 5.1.1
1 participant
@peterzsohar