Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace launcher plugin #61

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Replace launcher plugin #61

merged 3 commits into from
Dec 18, 2024

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Dec 17, 2024

This PR replaces the JupyterLab provided plugin @jupyterlab/launcher-extension:plugin and provides its own, such that the launcher creates the selected item either in the default FileBrowser with the local storage or the DriveFileBrowser within the available drives.

The IFileBrowserFactory is used to get the current file browser used when opening it. It defaults to the DriveBrowser when first launching JupyterLab as it get the recently added file browser, if none was in focus.

It should provide a temporary fix for this issue: #45.

@DenisaCG DenisaCG added the bug Something isn't working label Dec 17, 2024
@DenisaCG DenisaCG self-assigned this Dec 17, 2024
Copy link

Binder 👈 Launch a Binder on branch DenisaCG/jupyter-drives/lancher

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's get this upstream in JupyterLab so that it's only temporary here.

@DenisaCG DenisaCG merged commit 7dd020c into QuantStack:main Dec 18, 2024
7 checks passed
@DenisaCG DenisaCG deleted the lancher branch December 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants