Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: upgrade anaconda and ga workflow versions #239

Closed
wants to merge 2 commits into from
Closed

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 13, 2024

This PR

  • upgrades to anaconda=2024.02
  • upgrades GitHub action workflow versions to latest

@mmcky mmcky mentioned this pull request Mar 13, 2024
1 task
@mmcky
Copy link
Contributor Author

mmcky commented Mar 13, 2024

@doctor-phil
Copy link
Collaborator

@mmcky Numba is not used directly in the notes as far as I know, so we can probably get away with removing the pinned version from the environment

@mmcky
Copy link
Contributor Author

mmcky commented Mar 14, 2024

thanks @doctor-phil -- oh I see numba == 0.56.4 which should actually work. I think when I updated to anaconda=2024.02 the pins are incompatible due to the number of downgrades?

@@ -3,7 +3,7 @@ channels:
- default
dependencies:
- python=3.9
- anaconda=2022.10
- anaconda=2024.02
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the pip install fails when specifying 2024.02 so maybe we can revert this to update the GitHub actions infrastructure

@doctor-phil
Copy link
Collaborator

doctor-phil commented Mar 14, 2024

ERROR: No matching distribution found for interpolation==2.2.4

@mmcky seems like you're right.

@mmcky
Copy link
Contributor Author

mmcky commented Mar 18, 2024

@doctor-phil let's wait on EconForge/interpolation.py#112 and then re-run with a new pin

@mmcky
Copy link
Contributor Author

mmcky commented Apr 29, 2024

@doctor-phil it looks like the pip pins are too much for the new 2024 anaconda distribution -- probably too many downgrades. I will leave this open but let me know if I can help in any way.

@doctor-phil
Copy link
Collaborator

@mmcky there are a lot of downgrades. But I'm actually not sure if numba or interpolations are used anywhere

@mmcky
Copy link
Contributor Author

mmcky commented May 21, 2024

@doctor-phil is there a reason for such a restrictive build environment? Can we relax the version pins?

@doctor-phil
Copy link
Collaborator

@mmcky we can relax some of them I think, these are the pins that I put in place in #225 to avoid the constant build failures due to third-party package upgrades.

@mmcky
Copy link
Contributor Author

mmcky commented Nov 8, 2024

Closing this as merged in #265

@mmcky mmcky closed this Nov 8, 2024
@mmcky mmcky deleted the maint-13mar2024 branch November 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants